OCPSTRAT-1677: feat: allow for aws spot market options on node pools - #6707

api/hypershift/v1beta1/aws.go (1)

61-65: Enforce mutual exclusivity (Spot vs CapacityReservation) and tenancy constraint at the API (CEL).

Controller-only validation is insufficient. Add type-level CEL to AWSNodePoolPlatform so invalid specs never persist. Also, Spot is not supported with dedicated/host tenancy; enforce tenancy=default when spotMarketOptions is set.

Add these validations at the AWSNodePoolPlatform type (type-level, not field-level):

- type AWSNodePoolPlatform struct {
+// +kubebuilder:validation:XValidation:rule="!(has(self.spotMarketOptions) && has(self.placement) && has(self.placement.capacityReservation))",message="spotMarketOptions cannot be used with placement.capacityReservation"
+// +kubebuilder:validation:XValidation:rule="!(has(self.spotMarketOptions) && has(self.placement) && has(self.placement.tenancy) && self.placement.tenancy != 'default')",message="spotMarketOptions require placement.tenancy to be 'default'"
+type AWSNodePoolPlatform struct {

docs/content/how-to/aws/create-aws-hosted-cluster-spot-instances.md (3)

1-108: Scope this under automated machine management and avoid re-documenting cluster creation.

Per prior feedback, fold this into the existing “Automated machine management” how-to, focusing on NodePool specifics; link to Getting Started for cluster creation.

---

14-21: CLI IAM step should be automated by the CLI IAM management.

Either remove or caveat this section; if kept, clearly state when it’s needed.

---

145-145: Clarify replacement behavior and termination handling.

CAPI/MachineDeployments will recreate instances to meet replicas, but graceful handling of 2‑minute interruptions needs a termination handler; don’t imply it “automatically handles” without detailing the mechanism.

- - HyperShift automatically handles instance replacement when Spot instances are terminated
+ - The control plane will recreate instances to maintain desired replicas when Spot instances are terminated. For graceful drains on the 2‑minute notice, deploy a termination handler DaemonSet (e.g., AWS Node Termination Handler).

api/hypershift/v1beta1/aws.go (2)

67-74: Tighten MaxPrice validation and clarify units.

Cap the decimal precision and state “per instance-hour” explicitly.

- // The price is specified in USD. If omitted, the On-Demand price is used as the max price.
+ // The price is specified in USD per instance-hour. If omitted, the On-Demand price is used as the max price.
- // +kubebuilder:validation:Pattern=`^[0-9]+(\.[0-9]+)?$`
+ // +kubebuilder:validation:Pattern=`^[0-9]+(\.[0-9]{1,5})?$`

---

95-95: Typo in comment.

-// MarketType describes the market type of the CapacityReservationo for an Instance.
+// MarketType describes the market type of the CapacityReservation for an Instance.

vendor/github.com/openshift/hypershift/api/hypershift/v1beta1/aws.go (1)

95-95: Mirror typo fix in vendor.

Keep comments consistent with the source API.

-// MarketType describes the market type of the CapacityReservationo for an Instance.
+// MarketType describes the market type of the CapacityReservation for an Instance.

docs/content/how-to/aws/create-aws-hosted-cluster-spot-instances.md (1)

70-77: Minor grammar tweak.

-When completed, extract the credentials for workload cluster:
+When complete, extract the workload cluster credentials:

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

docs/content/how-to/automated-machine-management/aws-spot-instances.md (2)

14-21: Fix list/code block indentation (markdownlint MD007/MD046).

Bullets under prerequisites are over-indented; fenced blocks should be nested under the bullet with two-space indent.

Apply:

-    - You can verify if the role already exists using the following command:
-  ```sh
-  aws iam get-role --role-name AWSServiceRoleForEC2Spot
-  ```
-    - If the role does not exist, create it with:
-  ```sh
-  aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
-  ```
+  - You can verify if the role already exists using:
+    ```sh
+    aws iam get-role --role-name AWSServiceRoleForEC2Spot
+    ```
+  - If the role does not exist, create it with:
+    ```sh
+    aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
+    ```

---

94-94: Document the exact maxPrice format to match the CRD.

Align text with validation: digits/precision and no leading zeros (except "0"). Include valid/invalid examples.

Apply:

-- **maxPrice** (optional): The maximum price per hour that you're willing to pay for a Spot instance, specified in USD. If omitted, the On-Demand price is used as the maximum price.
+- **maxPrice** (optional): The maximum price per hour (USD). If omitted, the On-Demand price is used. Format: up to 10 integer digits and up to 6 fractional digits; no leading zeros unless the value is exactly "0"; scientific notation not allowed. Examples: "0", "0.0739", "1234567890.123456". Invalid: "00.10", "1.", ".5", "1.1234567".

-3. Check that your `maxPrice` format is valid (numeric string in USD)
+3. Check that your `maxPrice` format is valid (numeric string in USD; up to 10 integer digits and 6 fractional digits; no leading zeros unless "0")

Also applies to: 205-208

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-TechPreviewNoUpgrade.crd.yaml (1)

528-533: CEL rule/message alignment resolved as previously requested.

Message now states “‘default’ or unset,” matching the rule. Good catch and fix.

test/e2e/create_cluster_test.go (1)

1795-1865: Deduplicate the expected error string to avoid drift.

Define a local constant and reuse it across these cases to keep tests resilient to future message tweaks.

Add near the top of this test file:

const spotError = "spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')"

Then replace the repeated string literals in these cases with spotError.

hypershift-operator/controllers/nodepool/aws_test.go (2)

543-666: Factor out the unified error message literal.

Use a shared constant in this file to avoid message drift and copy-paste.

Example:

const spotErr = "spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')"

Replace the repeated literals in failing cases with spotErr.

---

543-666: Optional: add a MaxPrice format rejection test.

Consider a controller-level test asserting that an invalid maxPrice (e.g., "00.10", ".5", "1.1234567") surfaces the API validation error, complementing CRD/e2e coverage.

api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests/nodepools.hypershift.openshift.io/AAA_ungated.yaml (1)

493-501: Spot options schema and price regex look good; tweak dashes in docs.

Schema/regex are correct and bounded (maxLength 17 aligns with 10+1+6). Minor nit: replace typographic dashes with ASCII hyphens to avoid encoding surprises in generators/tooling.

-                                  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-                                  If omitted, the On‑Demand price is used as the ceiling.
+                                  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+                                  If omitted, the On-Demand price is used as the ceiling.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-CustomNoUpgrade.crd.yaml (1)

496-504: Spot options schema: solid bounds; unify hyphens in description.

Validation matches intended format; minor doc nit on typographic dashes.

-                                  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-                                  If omitted, the On‑Demand price is used as the ceiling.
+                                  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+                                  If omitted, the On-Demand price is used as the ceiling.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-TechPreviewNoUpgrade.crd.yaml (1)

496-504: Spot options schema OK; normalize hyphens in docs.

Same nit as other CRDs: prefer ASCII hyphens.

-                                  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-                                  If omitted, the On‑Demand price is used as the ceiling.
+                                  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+                                  If omitted, the On-Demand price is used as the ceiling.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests/nodepools.hypershift.openshift.io/AAA_ungated.yaml (1)

525-530: Ensure the CEL rule/message appears in every NodePool CRD variant

This rule/message is correct. Please verify it’s present across all generated NodePool CRDs (operator and feature‑gated) to avoid drift between variants.

Run:

#!/bin/bash
set -euo pipefail
pat_rule="has\\(self\\.spotMarketOptions\\) \\? \\(!has\\(self\\.capacityReservation\\) && \\(!has\\(self\\.tenancy\\) \\|\\| self\\.tenancy == 'default'\\)\\) : true"
pat_msg="spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')"
for d in cmd/install/assets/hypershift-operator/zz_generated.crd-manifests api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests; do
  echo "Scanning $d"
  mapfile -t files < <(fd -t f -g 'nodepools*.yaml' "$d")
  for f in "${files[@]}"; do
    have_rule=$(rg -n "$pat_rule" "$f" || true)
    have_msg=$(rg -n "$pat_msg" "$f" || true)
    [[ -z "$have_rule" || -z "$have_msg" ]] && echo "MISSING in $f"
  done
done

api/hypershift/v1beta1/aws.go (1)

62-71: Confirm MaxPrice validation parity with any vendored/api duplicates

The stricter Pattern/MaxLength are fine, but please ensure any duplicate AWSSpotMarketOptions definitions (e.g., vendor copies) use the same annotations to prevent CRD/codegen drift.

Run:

#!/bin/bash
set -euo pipefail
echo "Definitions of AWSSpotMarketOptions across repo:"
rg -nPU '(?s)^type\s+AWSSpotMarketOptions\b.*?\n}' -g '**/*.go'
echo
echo "MaxPrice validation tags:"
rg -n 'MaxPrice.*kubebuilder:validation' -g '**/*.go'

hypershift-operator/controllers/nodepool/aws.go (1)

169-175: Clear CapacityReservation fields when switching to Spot.

If Spot is set, carry-over CapacityReservation* fields from earlier placement processing can leak into the template. Clear them to avoid emitting mutually exclusive settings, even if CRD validation normally blocks such combos.

Apply:

 if nodePool.Spec.Platform.AWS.Placement != nil && nodePool.Spec.Platform.AWS.Placement.SpotMarketOptions != nil {
+    // Clear mutually exclusive CapacityReservation settings when using Spot.
+    awsMachineTemplateSpec.Template.Spec.CapacityReservationID = nil
+    awsMachineTemplateSpec.Template.Spec.CapacityReservationPreference = ""
     awsMachineTemplateSpec.Template.Spec.SpotMarketOptions = &capiaws.SpotMarketOptions{
         MaxPrice: nodePool.Spec.Platform.AWS.Placement.SpotMarketOptions.MaxPrice,
     }
     awsMachineTemplateSpec.Template.Spec.MarketType = capiaws.MarketTypeSpot
 }

Would you like a unit test ensuring these fields are nil/empty when SpotMarketOptions is set?

docs/content/how-to/automated-machine-management/aws-spot-instances.md (3)

14-21: Fix nested list indentation under Prerequisites (MD007/MD046).

Indent list items with two spaces and fence code blocks under the bullet (4 spaces).

-    - You can verify if the role already exists using the following command:
-  ```sh
-  aws iam get-role --role-name AWSServiceRoleForEC2Spot
-  ```
-    - If the role does not exist, create it with:
-  ```sh
-  aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
-  ```
+  - You can verify if the role already exists using the following command:
+    ```sh
+    aws iam get-role --role-name AWSServiceRoleForEC2Spot
+    ```
+  - If the role does not exist, create it with:
+    ```sh
+    aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
+    ```

---

94-94: Document exact maxPrice format to match CRD validation.

State digits/precision and give valid/invalid examples to avoid user errors.

-- **maxPrice** (optional): The maximum price per hour that you're willing to pay for a Spot instance, specified in USD. If omitted, the On-Demand price is used as the maximum price.
+- **maxPrice** (optional): Maximum price per hour (USD). If omitted, the On-Demand price is used. Format: up to 10 integer digits and up to 6 fractional digits; no leading zeros unless exactly "0"; scientific notation not allowed. Examples: "0", "0.0739", "1234567890.123456". Invalid: "00.10", "1.", ".5", "1.1234567".

---

205-207: Align validation step with CRD maxPrice constraints.

Mirror the precise format constraints users must follow.

-3. Check that your `maxPrice` format is valid (numeric string in USD)
+3. Check that your `maxPrice` format is valid (numeric string in USD; up to 10 integer digits and up to 6 fractional digits; no leading zeros unless "0")

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-Default.crd.yaml (1)

498-501: Replace non-ASCII hyphens in generated descriptions and regenerate CRDs.

“instance‑hour” and “On‑Demand” contain Unicode hyphens; switch to ASCII “-” in Go comments and re-run codegen.

-  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-  If omitted, the On‑Demand price is used as the ceiling.
+  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+  If omitted, the On-Demand price is used as the ceiling.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-CustomNoUpgrade.crd.yaml (1)

498-501: Fix Unicode hyphens in descriptions and regenerate CRDs.

Same non-ASCII hyphen issue here; replace in source comments and regenerate.

-  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-  If omitted, the On‑Demand price is used as the ceiling.
+  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+  If omitted, the On-Demand price is used as the ceiling.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-TechPreviewNoUpgrade.crd.yaml (1)

528-533: CEL rule/message alignment for Spot constraints looks good

Message now matches the rule (“'default' or unset”) and enforces incompatibility with capacityReservation. LGTM.

Run this quick check to ensure all NodePool CRDs carry the Spot field and the aligned validation:

#!/bin/bash
set -euo pipefail
echo "Scanning NodePool CRDs for spotMarketOptions and aligned validation..."
for f in $(fd -t f -g 'nodepools-*.crd.yaml' cmd/install/assets/hypershift-operator/zz_generated.crd-manifests); do
  echo "=== $f"
  rg -nC1 '\bspotMarketOptions\b' "$f" || echo "MISSING spotMarketOptions in $f"
  rg -nC1 "requires tenancy to be 'default' or unset" "$f" || echo "MISSING aligned message in $f"
  rg -nC1 "has\\(self\\.spotMarketOptions\\).*!has\\(self\\.capacityReservation\\).*self\\.tenancy == 'default'" "$f" || echo "MISSING CEL rule in $f"
done

test/e2e/create_cluster_test.go (1)

1795-1865: The repeated error string is already covered by a success case in test/e2e/nodepool_test.go, so you can drop the optional “add success-path” suggestion. Retain the nit: factor out the error message. Rewrite to:

Factor out repeated error message into a constant
Define at the top of this test block:

const spotIncompatibilityErr = "spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')"

Then replace each expectedErrorSubstring: "…" with

expectedErrorSubstring: spotIncompatibilityErr,

hypershift-operator/controllers/nodepool/aws.go (1)

312-314: Refine error for better operator diagnostics.

Returning a generic error is fine; consider including the NodePool name for context.

-    return fmt.Errorf("aws platform not populated")
+    return fmt.Errorf("aws platform not populated for NodePool %q", nodePool.Name)

docs/content/reference/api.md (2)

2533-2565: Spot options doc is clear; minor wording and typographic nits.

• Use normal hyphens instead of non-breaking ones in “instance‑hour” and “On‑Demand”.
• Consider clarifying accepted examples and keeping wording tight.

Apply this diff to tighten wording and fix hyphens:

-<p>maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-If omitted, the On‑Demand price is used as the ceiling.
-Example: “0.0739”
-Format: up to 10 integer digits and up to 6 fractional digits; no leading zeros unless the value is “0”; scientific notation is not allowed.</p>
+<p>maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+If omitted, the On-Demand price is used as the ceiling.
+Example: “0.0739”.
+Format: up to 10 integer digits and up to 6 fractional digits; no leading zeros unless the value is “0”; scientific notation is not allowed.</p>

---

10472-10487: Tighten exclusivity wording for Spot with tenancy/capacity reservations.

Clarify that Spot cannot be combined with dedicated/host tenancy and is exclusive with capacity reservations.

-<p>spotMarketOptions specifies options for using AWS Spot instances.
-When specified, instances will be launched as Spot instances with the given configuration.
-Mutually exclusive with capacityReservation, and tenancy must be unset or set to “default”.</p>
+<p>spotMarketOptions specifies options for using AWS Spot instances.
+When specified, instances will be launched as Spot instances with the given configuration.
+Mutually exclusive with <code>capacityReservation</code>; <code>tenancy</code> must be omitted or set to “default” (Spot is not supported with “dedicated” or “host” tenancy).</p>

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-TechPreviewNoUpgrade.crd.yaml (1)

490-505: Use ASCII hyphens in descriptions to avoid encoding/rendering glitches

Replace the non-breaking hyphen characters in "instance‑hour" and "On‑Demand" with regular ASCII hyphens.

-                                  maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
+                                  maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
-                                  If omitted, the On‑Demand price is used as the ceiling.
+                                  If omitted, the On-Demand price is used as the ceiling.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: maxcao13
PR: openshift/hypershift#0
File: :0-0
Timestamp: 2025-08-28T17:26:17.059Z
Learning: The Karpenter provisioner check pattern with potential nil pointer dereference appears in 4 locations in the hypershift codebase: test/e2e/util/util.go, hypershift-operator/controllers/nodepool/token.go, hypershift-operator/controllers/hostedcluster/karpenter.go, and control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go. A 5th location in control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/component.go already implements proper nil checks.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-Default.crd.yaml (1)

498-505: Regenerate after replacing non-ASCII hyphens in Go comments

Description shows non-ASCII hyphens (“instance‑hour”, “On‑Demand”). Replace them in api/hypershift/v1beta1/aws.go comments and re-run codegen so CRDs contain ASCII “-”.

cmd/install/assets/hypershift-operator/zz_generated.crd-manifests/nodepools-TechPreviewNoUpgrade.crd.yaml (1)

498-505: Regenerate after replacing non-ASCII hyphens in Go comments

Same non-ASCII hyphens here; fix in source comments and regenerate.

api/hypershift/v1beta1/aws.go (2)

64-66: Use ASCII hyphens in comments to avoid non-ASCII characters in generated CRDs

The comments contain non-ASCII hyphens (e.g., “instance‑hour”, “On‑Demand”). These leak into CRD descriptions and can trip tooling. Replace with ASCII "-".

-// maxPrice defines the maximum price (USD per instance‑hour) you are willing to pay for a Spot instance.
-// If omitted, the On‑Demand price is used as the ceiling.
+// maxPrice defines the maximum price (USD per instance-hour) you are willing to pay for a Spot instance.
+// If omitted, the On-Demand price is used as the ceiling.

Also applies to: 69-71

---

69-71: Verify MaxPrice validation tags match the vendored API to avoid drift

Pattern/MaxLength here (10 integer + up to 6 fractional digits; MaxLength=17) may differ from the vendored copy historically using a simpler pattern and MaxLength=15. Please confirm both sides match; regenerate CRDs if you change it.

I can provide a follow-up patch once you confirm which spec is authoritative.

hypershift-operator/controllers/nodepool/aws.go (2)

169-174: Clear CapacityReservation fields when enabling Spot to avoid conflicting template output

If placement had CapacityReservation set above, we’ll emit both CapacityReservation and Spot fields. Clear the CR-related fields before setting Spot for consistency.

 if nodePool.Spec.Platform.AWS.Placement != nil && nodePool.Spec.Platform.AWS.Placement.SpotMarketOptions != nil {
+    // Clear mutually exclusive CapacityReservation settings when using Spot.
+    awsMachineTemplateSpec.Template.Spec.CapacityReservationID = nil
+    awsMachineTemplateSpec.Template.Spec.CapacityReservationPreference = ""
     awsMachineTemplateSpec.Template.Spec.SpotMarketOptions = &capiaws.SpotMarketOptions{
         MaxPrice: nodePool.Spec.Platform.AWS.Placement.SpotMarketOptions.MaxPrice,
     }
     awsMachineTemplateSpec.Template.Spec.MarketType = capiaws.MarketTypeSpot
 }

---

330-337: Use precise, targeted validation messages (avoid conflating tenancy and capacityReservation)

Emit specific errors for each failed check; this improves UX and makes tests less brittle.

 if nodePool.Spec.Platform.AWS.Placement != nil && nodePool.Spec.Platform.AWS.Placement.SpotMarketOptions != nil {
     if nodePool.Spec.Platform.AWS.Placement.Tenancy != "" && nodePool.Spec.Platform.AWS.Placement.Tenancy != ec2.TenancyDefault {
-        return fmt.Errorf("spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')")
+        return fmt.Errorf("spotMarketOptions requires placement.tenancy to be 'default' or unset (not 'dedicated' or 'host')")
     }
     if nodePool.Spec.Platform.AWS.Placement.CapacityReservation != nil {
-        return fmt.Errorf("spotMarketOptions is incompatible with capacityReservation and requires tenancy to be 'default' or unset (not 'dedicated' or 'host')")
+        return fmt.Errorf("spotMarketOptions cannot be used with placement.capacityReservation")
     }
 }

Also align any test assertions to these exact strings.

docs/content/how-to/automated-machine-management/aws-spot-instances.md (3)

13-21: Fix list indentation and fenced code block nesting (MD007/MD046)

Indent list items by 2 spaces and nest fenced blocks under the bullet.

-    - You can verify if the role already exists using the following command:
-  ```sh
-  aws iam get-role --role-name AWSServiceRoleForEC2Spot
-  ```
-    - If the role does not exist, create it with:
-  ```sh
-  aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
-  ```
+  - You can verify if the role already exists using the following command:
+    ```sh
+    aws iam get-role --role-name AWSServiceRoleForEC2Spot
+    ```
+  - If the role does not exist, create it with:
+    ```sh
+    aws iam create-service-linked-role --aws-service-name spot.amazonaws.com
+    ```

---

94-94: Align maxPrice documentation with CRD validation (digits/precision examples)

Document the exact accepted format to match API validation; add valid/invalid examples.

-- **maxPrice** (optional): The maximum price per hour that you're willing to pay for a Spot instance, specified in USD. If omitted, the On-Demand price is used as the maximum price.
+- **maxPrice** (optional): The maximum price per hour (USD). If omitted, the On-Demand price is used.
+  Format: up to 10 integer digits and up to 6 fractional digits; no leading zeros unless exactly "0".
+  Examples: "0", "0.0739", "1234567890.123456". Invalid: "00.10", "1.", ".5", "1.1234567".

-3. Check that your `maxPrice` format is valid (numeric string in USD)
+3. Check that your `maxPrice` format is valid (numeric string in USD, up to 10 integer digits and 6 fractional digits; no leading zeros unless "0")

Also applies to: 206-208

---

1-221: Run docs linters (wrap/blank lines/trailing newline) to catch residual nits

Address MD013/MD031/MD032/MD047 if reported after your last edits.

I can run markdownlint/codespell locally and push a formatting-only patch if helpful.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: maxcao13
PR: openshift/hypershift#0
File: :0-0
Timestamp: 2025-08-28T17:26:17.059Z
Learning: The Karpenter provisioner check pattern with potential nil pointer dereference appears in 4 locations in the hypershift codebase: test/e2e/util/util.go, hypershift-operator/controllers/nodepool/token.go, hypershift-operator/controllers/hostedcluster/karpenter.go, and control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go. A 5th location in control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/component.go already implements proper nil checks.